Skip to content

fix: wrong stats when running with workers #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kobenguyent merged 2 commits into from
Sep 26, 2025
Merged

fix: wrong stats when running with workers #5215

kobenguyent merged 2 commits into from
Sep 26, 2025
+39 −1

Conversation

@kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Sep 24, 2025

Motivation/Description of the PR

  • Description of this PR, which problem it solves
  • Resolves #issueId (if applicable).

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit db7d0fc into 3.x Sep 26, 2025
19 of 22 checks passed
@kobenguyent kobenguyent deleted the fix-wrong-stats-run-workers branch September 26, 2025 07:58
@kobenguyent kobenguyent mentioned this pull request Jan 15, 2026
Merged
@mirao
Copy link
Contributor

mirao commented Jan 23, 2026

@kobenguyent
There is a performance regression with workers. It worsened in 3.7.6 when comparing 3.7.5. Not sure if it's caused by changes in the PR. Just let you know. I don't use workers in my environment (I use run-multiple instead which works fine for me), I just wondered how workers work so I tried them.

The test is running 2 suites in 3 browsers.

3.7.6 is slow 🐞, the test takes 2m15s (tested multiple times)

mirao@rog:~/workspace/codeceptjs/tests/s4e$ time codeceptjs run-workers 3 dev --suites --grep "ClassPrepara
tion|CourseDetails" --profile dev
CodeceptJS v3.7.6 #StandWithUkraine
Running tests in 3 workers...

[Worker 05]   ✔ ClassPreparation @group1 › Get an admin token in 249ms
[Worker 04]   ✔ ClassPreparation @group1 › Get an admin token in 243ms
...

  OK  | 129 passed   // 2m

real    2m15.932s
user    1m50.979s
sys     0m6.577s

3.7.5 is fast ✔️ , the test takes 1m20s (tested multiple times)

mirao@rog:~/workspace/codeceptjs/tests/s4e$ time codeceptjs run-workers 3 dev --suites --grep "ClassPreparation|CourseDetails" --profile dev
CodeceptJS v3.7.5 #StandWithUkraine
Running tests in 3 workers...

[07]   ✔ Get an admin token in 237ms
[08]   ✔ Get an admin token in 240ms
...
  OK  | 129 passed   // 1m

real    1m20.479s
user    1m50.740s
sys     0m6.901s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomashohn thomashohn thomashohn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kobenguyent @mirao @thomashohn